Skip to content

Conversation

@jimmyl0l3c
Copy link
Contributor

@jimmyl0l3c jimmyl0l3c commented Feb 14, 2022

@nickvergessen
Copy link
Member

Might want to join forces with #478 ?

@jimmyl0l3c
Copy link
Contributor Author

I'm not sure about joining with sharerenamer. With all due respect, but I dont like sharerenamer's approach and I would like to keep my app as an alternative to sharerenamer, if that's possible. (Differences can be seen in the screenshots I added to readme recently)
And I'm sorry for the delayed reply.

@vitormattos
Copy link

vitormattos commented Mar 2, 2022

@vitormattos
Copy link

vitormattos commented Mar 2, 2022

@jimmyl0l3c
Suggestions:
rename your repository from cfg-share-links to cfgsharelinks
OR: rename your repository from cfg-share-links to cfg_share_links and change the app_id to cfg_share_links

Motivation: Make more easy to new developers clone the repository and start to work without necessity to rename the repository folder to same name of app_id

Only a suggestion, waiting for your opinion to go ahead.

@jimmyl0l3c
Copy link
Contributor Author

Thank you for suggestion and I agree. I will change the app_id and rename repository.
But I need to generate new certificate, am I right?

@vitormattos
Copy link

vitormattos commented Mar 2, 2022

I think that will be not necessary generate but, isn't a problem to generate a new certificate, rename the folder and certificate name to maintain equals to app_id. This isn't a problem to do this for now because we don't merged your certificate to app certificate repository.

@jimmyl0l3c
Copy link
Contributor Author

jimmyl0l3c commented Mar 2, 2022

But "Subject" field in certificate request would be wrong if I didnt generate new one. Isn't it a problem?

Certificate Request:
    Data:
        Version: 1 (0x0)
        Subject: CN = cfgsharelinks
...

EDIT: Also I may have misunderstood the beginning of your post. I will push new certificate in a minute.

@jimmyl0l3c
Copy link
Contributor Author

jimmyl0l3c commented Mar 2, 2022

App_id is changed, repo renamed and I committed new certificate.

@vitormattos
Copy link

Beautiful! Can you squash all into only one commit?

@vitormattos vitormattos changed the title Create cfgsharelinks.csr Create cfg_share_links.csr Mar 2, 2022
Signed-off-by: jimmyl0l3c <[email protected]>
@vitormattos vitormattos merged commit 1e744cb into nextcloud:master Mar 3, 2022
@vitormattos
Copy link

crt here: d2a4ca6

@jimmyl0l3c
Copy link
Contributor Author

Thank you

@jimmyl0l3c jimmyl0l3c deleted the patch-1 branch March 3, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants