-
Notifications
You must be signed in to change notification settings - Fork 301
Create cfg_share_links.csr #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Might want to join forces with #478 ? |
|
I'm not sure about joining with sharerenamer. With all due respect, but I dont like sharerenamer's approach and I would like to keep my app as an alternative to sharerenamer, if that's possible. (Differences can be seen in the screenshots I added to readme recently) |
|
@jimmyl0l3c Motivation: Make more easy to new developers clone the repository and start to work without necessity to rename the repository folder to same name of app_id Only a suggestion, waiting for your opinion to go ahead. |
|
Thank you for suggestion and I agree. I will change the app_id and rename repository. |
|
I think that will be not necessary generate but, isn't a problem to generate a new certificate, rename the folder and certificate name to maintain equals to app_id. This isn't a problem to do this for now because we don't merged your certificate to app certificate repository. |
|
But "Subject" field in certificate request would be wrong if I didnt generate new one. Isn't it a problem? EDIT: Also I may have misunderstood the beginning of your post. I will push new certificate in a minute. |
|
App_id is changed, repo renamed and I committed new certificate. |
|
Beautiful! Can you squash all into only one commit? |
Signed-off-by: jimmyl0l3c <[email protected]>
|
crt here: d2a4ca6 |
|
Thank you |
https://github.com/jimmyl0l3c/cfg_share_links